Checkbox not reflecting actual "enabled" status of interface in link settings

spr-networks / super

📡 SPR: Open Source, secure, user friendly and fast wifi routers for your home. One wifi password per device. Ad Blocking & Privacy Blocklists. Policy Based Network Access

https://www.supernetworks.org/

BSD 3-Clause "New" or "Revised" License

165 stars 12 forks source link

Checkbox not reflecting actual "enabled" status of interface in link settings #330

Closed avlidienbrunn closed 2 months ago

avlidienbrunn commented 3 months ago

Description

When editing interface settings in /admin/uplink (click triple dot -> Modify Interface), the checkbox displaying "enabled" status does not reflect the value of the setting. The checkbox is always checked, regardless of wether the interface is "enabled" or not.

The green ENABLED label works as intended:

lts-rad commented 3 months ago

picking this up now. seeing the onClose not defined error as well

lts-rad commented 3 months ago

[x] fix scroll view for uplink
[x] fix onClose for lan link view
[x] fix ssid escaping
[x] fix dhcp
[x] fix enable/disable toggle on uplink

lts-rad commented 3 months ago

3cca32da1a747e7a8a32f1434c099374136a3701

lts-rad commented 3 months ago

Next release should have this fix