Compiling WCSimPMTObject.cc ...
src/WCSimPMTObject.cc: In member function ‘void WCSimBasicPMTObject::DefineQEHist(std::map<double, double>)’:
src/WCSimPMTObject.cc:2045:73: warning: declaration of ‘mapQE’ shadows a member of 'this' [-Wshadow]
void WCSimBasicPMTObject::DefineQEHist(std::map<G4double,G4double> mapQE){
Shadowing
Adopted the conventional solution of updating the names of all private and protected data members to begin with f.
Conclusion
After these changes, there are no more compiler warnings from WCSimPMTObject.
It looks like the implementation of WCSimBasicPMTObject may be incomplete. It maintains in parallel two representations of the quantum efficiency curves, but these may not be maintained consistently.
Warnings in WCSimPMTObject
Warning text
Shadowing
Adopted the conventional solution of updating the names of all private and protected data members to begin with
f.Conclusion
After these changes, there are no more compiler warnings from
WCSimPMTObject.It looks like the implementation of
WCSimBasicPMTObjectmay be incomplete. It maintains in parallel two representations of the quantum efficiency curves, but these may not be maintained consistently.Originally posted by @spradlin in https://github.com/spradlin/WCSim/issues/9#issuecomment-1002398098