search

sprain / php-swiss-qr-bill

A PHP library to create Swiss QR bills | QR-Rechnung in PHP erstellen
MIT License
281 stars 82 forks source link

Scissors wrongly positioned in HtmlOutput #266

Open sprain opened 4 days ago

sprain commented 4 days ago

Scissors positioning in HtmlOutput is not always as expected.

This needs further reproduction and digging into.

Bildschirmfoto_2024-11-11_um_11_05_14

kohlerdominik commented 3 days ago

Probably should also inform @tafel here, so they can keep their eyes open.

tafel commented 3 days ago

Is this from the raw HTML in the browser, or after transforming it into a PDF? If it's a PDF, what is the translator html>pdf?

sprain commented 3 days ago

It's in a converted pdf, but already looks wrong in HTML. I changed position behaviour in my PR and probably overlooked the case when the payment slip will be moved around on the page.

tafel commented 3 days ago

I saw you changed the position to fixed. It's probably what's causing the problem. Check this video

https://github.com/user-attachments/assets/19eea553-0c35-4fd1-9312-37fb859fbc45

Do you remember what was the reason for fixed position?

sprain commented 3 days ago

Do you remember what was the reason for fixed position?

Yes, the previous positioning actually changed the size of the whole payment slip, making it higher by the size of the scissors.