search

spray / spray-json

A lightweight, clean and simple JSON implementation in Scala
Apache License 2.0
973 stars 190 forks source link

Version 1.3.0 incompatible with spray-httpx 1.3.1 #118

Closed agourlay closed 10 years ago

agourlay commented 10 years ago

I think the new spray-json 1.3.0 is incompatible with current spray-routing 1.3.1

Have a look at this stacktrace.

[ERROR] Uncaught error from thread [pomf-akka.actor.default-dispatcher-20] shutting down JVM since 'akka.jvm-exit-on-fatal-error' is enabled for ActorSystem[pomf]
[ERROR] java.lang.NoSuchMethodError: spray.json.JsonParser$.apply(Ljava/lang/String;)Lspray/json/JsValue;
[ERROR]        at spray.httpx.SprayJsonSupport$$anonfun$sprayJsonUnmarshaller$1.applyOrElse(SprayJsonSupport.scala:36)
[ERROR]        at spray.httpx.SprayJsonSupport$$anonfun$sprayJsonUnmarshaller$1.applyOrElse(SprayJsonSupport.scala:34)
[ERROR]        at scala.runtime.AbstractPartialFunction.apply(AbstractPartialFunction.scala:36)
[ERROR]        at spray.httpx.unmarshalling.Unmarshaller$$anon$1$$anonfun$unmarshal$1.apply(Unmarshaller.scala:29)
[ERROR]       ...

It appears spray-httpx uses an apply method that has disappeared. https://github.com/spray/spray/blob/master/spray-httpx/src/main/scala/spray/httpx/SprayJsonSupport.scala#L36 from https://github.com/spray/spray-json/commit/43a2319910f1c58c044aadbbb726bdc8a9f9229c#diff-3cad8170296c5b48752df35b7a89db77L109

WDYT?

sirthias commented 10 years ago

Yeah, true. We'll have to update spray itself to be compatible with spray-json 1.3.0.

sirthias commented 10 years ago

Duplicate of https://github.com/spray/spray/issues/932

agourlay commented 10 years ago

:+1: