spray / spray-json

A lightweight, clean and simple JSON implementation in Scala
Apache License 2.0
972 stars 190 forks source link

"no reflection" white lie on the README front page #171

Open RichardBradley opened 8 years ago

RichardBradley commented 8 years ago

See https://groups.google.com/forum/#!msg/spray-user/hH6q6E8xwto/eSL8sN0zCgAJ

The README opens with the bold claim that spray-json has:

Type-class based (de)serialization of custom objects (no reflection, no intrusion)

... but as you can see at ProductFormats.extractFieldNames, there is runtime reflection used in the Type-class based (de)serializers to get the property names for Case Classes.

Maybe this claim needs a footnote that it is only 99% true?

(see also #59 which might make this claim true, if it gets merged)