search

spray / spray-json

A lightweight, clean and simple JSON implementation in Scala
Apache License 2.0
974 stars 190 forks source link

+#182 allows BigInt/BigDecimal to be obtained from JsStrings #183

Closed ktoso closed 8 years ago

ktoso commented 8 years ago

Resolves https://github.com/spray/spray-json/issues/182

Hopefully non-controversial, as it does not slow down the typical case of parsing from number

ktoso commented 8 years ago

Failure was unrelated, I wonder why hm:

java.lang.UnsupportedClassVersionError: scala/tools/nsc/Main : Unsupported major.minor version 52.0
    at java.lang.ClassLoader.defineClass1(Native Method)
    at java.lang.ClassLoader.defineClass(ClassLoader.java:800)
patriknw commented 8 years ago

LGTM

afinkenstadt commented 8 years ago

👍

sirthias commented 8 years ago

Thanks, Konrad! This really is uncontroversial, as you say... :)

ktoso commented 8 years ago

Great, thanks @sirthias :-)

ktoso commented 8 years ago

How much other contribs do you think we should accumulate to be worthy of a release btw @sirthias? There's no rush on this one but wanted to have a ballpark estimate (maybe spend some time helping out etc)

sirthias commented 8 years ago

There really is no rule whatsoever regarding this. So far we've simply released whenever there was sufficient reason to do so.

In general the development pressure behind spray-json has been reduced significantly in recent years, also (in part) in order to motivate people to migrate to newer and better supported Scala JSON solutions. But it seems spray-json simply refuses to be abandoned by its users... :)

ktoso commented 8 years ago

I think we may be a at fault here ;-) Might write more docs about how to use other JSON libs in Akka HTTP docs - i.e. circe looks interesting.

sirthias commented 8 years ago

Yes, circe does look great. So, to build on my last point, there is some value in not releasing new spray-json versions unless really necessary...

afinkenstadt commented 8 years ago

For various reasons we (a consumer of spray-can) assumed that sticking with spray-json was the most correct thing to do, minimizing potential support issues or finger-pointing between competing or conflicting vendor packages. Therefore we leveraged the perceived blessing of spray-json when using the sum of all the spray-can packages.

Development pressure is reduced because it "just works". Congratulations. 😸

Warning 6 for https://github.com/travisbrown/circe would give pause, as that is exactly the problem this particular PR solved.