search

spray / spray-json

A lightweight, clean and simple JSON implementation in Scala
Apache License 2.0
974 stars 190 forks source link

Clean compilation warnings #215

Closed ackratos closed 6 years ago

ackratos commented 7 years ago

We have 47 compile warning in spray json about ClassManifest is deprecated and 1 warning in test about Unit inference is deprecated.

I want clean them to enhance the code quality without impact the functionality.

I am doing this because I want customize spray-json in my own project to support syntax extension. Unfortunately, my project is compiled with -Xfatal-warning scala compiler option and I don't want violates this limitation to make my project vulnerable to compile warnings.

So could you please review/merge my PR make the spray-json free of compilation warning? Thank you very much!

ktoso commented 7 years ago

That specific change changes signatures and therefore breaks binary compat. Seems we would need a new major release of it.

jrudolph commented 6 years ago

Fixed by #219.