replace pimp with 'rich', 'enrich', 'extension method'

spray / spray-json

A lightweight, clean and simple JSON implementation in Scala

Apache License 2.0

972 stars 190 forks source link

replace pimp with 'rich', 'enrich', 'extension method' #236

Closed SethTisue closed 6 years ago

SethTisue commented 7 years ago

(this was called to my attention on the “LGBTQ in Tech” Slack)

mgrandi commented 7 years ago

you could wait till a major release when binary compatibility isn't as much as a concern?

ktoso commented 7 years ago

We don't anticipate ever having to make such release so far though - compatibility is this libs strongest asset by now

ktoso commented 7 years ago

We could keep the old methods but mark them deprecated which would leave this change binary compatible and good-will showing

SethTisue commented 7 years ago

they who live in MiMa-less houses shouldn't throw bincompat stones :-)

SethTisue commented 7 years ago

revised version — that also adds MiMa to the build — ready for review

Travis says:

[info] spray-json: found 0 potential binary incompatibilities while checking against io.spray:spray-json_2.10:1.3.3 
[info] spray-json: found 0 potential binary incompatibilities while checking against io.spray:spray-json_2.11:1.3.3 
[info] spray-json: found 0 potential binary incompatibilities while checking against io.spray:spray-json_2.12:1.3.3

ktoso commented 6 years ago

Merging this, FYI @jrudolph

jrudolph commented 6 years ago

Great, thanks, @SethTisue for taking care of it.

SethTisue commented 6 years ago

I see. @ktoso, do you want to add something about it to the 1.3.4 release notes? (I'd do it myself but I don't have admin powers here.)

ktoso commented 6 years ago

Yeah I'll add such note. It's only with the specific by name import of previous method that breaks AFAICS

ktoso commented 6 years ago

Added a note