Open jkugiya opened 6 years ago
Hope this will be merged soon!
@jrudolph Regexs are so slow...
More simple and efficient functions which can enforce kebab case too are here
@jrudolph Regexs are so slow...
Yes, the reason for this implementation is regex's performance. But I can understand regex is easier to maintain. I created another PR(#295). I'll leave it up for either.
@plokhotnyuk I also tried your implementation. But some of the behavior is unexpected for me in some corner case.
ex)
^There-arE_Non_(Alphabetic))_character!S
-> ^_there_-ar_e__non_(_alphabetic_))_character_!s
(The capital letter is followed by _
.)There are space character
-> _there_ are_ space_ character_
(it start with _
)It is difficult to judge which is better because there aren't standard specification for this conversion, as far as I know.
Close #170