search

spray / spray-json

A lightweight, clean and simple JSON implementation in Scala
Apache License 2.0
972 stars 190 forks source link

Replace ClassManifest usages by ClassTag #270

Closed jrudolph closed 6 years ago

jrudolph commented 6 years ago

Binary compatible because ClassManifest is an alias to ClassTag since its inception.

Fixes #215.

jrudolph commented 6 years ago

Just figured we rejected almost the same change several times in #219 and #216. By now we have mima checks so we can actually verify that it's binary compatible. As stated above it actually is because ClassManifest is an alias to ClassTag which isn't reflected in any way in the class files. It is also source compatible for the same reason.

jrudolph commented 6 years ago

I'd suggest to merge this one after verification (just because it's rebased and uses slightly more elegant classTag instead of implicitly[ClassTag].

jrudolph commented 6 years ago

I fixed up #219, so we can use that one.