search

spray / spray-json

A lightweight, clean and simple JSON implementation in Scala
Apache License 2.0
969 stars 190 forks source link

Building with scala 3 #342

Open raboof opened 3 years ago

raboof commented 3 years ago

Fixes #341

jrudolph commented 3 years ago

I added a fix for the self-type issue but the tests don't compile cleanly any more, mostly because the new version of specs is not syntax compatible with the old.

raboof commented 3 years ago

I added a fix for the self-type issue

Nice!

but the tests don't compile cleanly any more, mostly because the new version of specs is not syntax compatible with the old.

Ah, we can use a cross-dependency for the tests https://github.com/etorreborre/specs2/issues/848

jrudolph commented 3 years ago

Cool, I fixed all the compilation issues but now it seems that

jrudolph commented 3 years ago

ProductFormats don't work any more, probably because Scala compilation changed the way fields are encoded

Ultimately, we would want to use derivation in Scala 3, but I guess it would be nice to support it in a simpler way until then?

jrudolph commented 2 years ago

Fixed the remaining issues, was pretty trivial after all.

raboof commented 2 years ago

/cc @jrudolph this might now be good to go?

hughsimpson commented 1 year ago

Is this dead?

raboof commented 1 year ago

With #345 merged and https://repo1.maven.org/maven2/io/spray/spray-json_3/1.3.6/ published this PR isn't so urgent anymore - the project is in 'maintainance mode' (https://github.com/spray/spray-json#maintanance-mode) and perhaps there won't even really be a need for a 1.4.x release