search

spray / twirl

The Play framework Scala template engine, stand-alone and packaged as an SBT plugin
Apache License 2.0
215 stars 20 forks source link

Updates Twirl with latest updates from origin Play TE #16

Closed 4lex1v closed 10 years ago

4lex1v commented 10 years ago

I've also did some quick code style fixes and updated build dependencies. Twirl updated to this commit

jrudolph commented 10 years ago

Thanks, for doing another round of updates. I've just finished a merge that tried to make your older changes also work for Scala 2.9. I'll see if that still works for this one.

jrudolph commented 10 years ago

Do you know in how far this version is still compatible with the old one?

4lex1v commented 10 years ago

They did some API changes and improvements, but code still should be compatible with scala 2.9, i didn't notice any 2.10 features. They have little changes in the compiler, e.g my previous twirl version and latest Play version). Although it's easy to make it fully compatible, i didn't want to touch original play implementation of the compiler or it would be harder to update it further.

jrudolph commented 10 years ago

From looking at the history it seems they merely changed the formatting and made small changes to the runtime classes. My main concern was that there were some changes that changed the syntax itself but it seems that didn't happen at all. Now I'll "just" have to do a re-merge of your changes and see where this will lead us to...

jrudolph commented 10 years ago

It seems I spoke to soon, there's lots more history that was hidden behind file renamings, so there have been more changes.

4lex1v commented 10 years ago

Well, templates (scala.html files) in tests doesn't have any changes in syntax, so, i guess, there were no changes with template syntax.

jrudolph commented 10 years ago

I incorporated your commits into the below sbt-0.13 branch and added a bit of compatibility stuff so that it also compiles for Scala 2.9.x. Can you try the new 0.7.0-SNAPSHOT version? You'll probably have to add this resolver to plugins.sbt:

resolvers += Classpaths.sbtPluginSnapshots

sbt 0.13 branch: https://github.com/spray/twirl/commits/i/15/try-to-convert-to-sbt-0.13