spreadsheetimporter / ui5-cc-spreadsheetimporter

A UI5 Component to integrate a Spreadsheet Upload for UI5 Apps.
https://spreadsheet-importer.com/
Apache License 2.0
82 stars 16 forks source link

[Bug]: Date column in excel is converted to user time zone date #484

Closed mainakaich closed 8 months ago

mainakaich commented 8 months ago

OData Version

OData V4

Draft

Yes

Scenario

Fiori Elements

Environment

BTP ABAP

UI5 Spreadsheet Component

cc.spreadsheetimporter.v0_31_4

What happened?

I am uploading an excel file which has date in format MM/DD/YY. My computer time zone is UTC-5 hours i.e. USA EST time zone. Now when I upload the excel file, the date field value is converted to EST time. E.g., I am attaching an excel file here. When I upload this file, in preview it is changed to 14th Feb and 29th Feb. Upload Article Supersession Template 01-31-2024.xlsx excel upload show preview

Relevant log output

I will share if required

Spreadsheet Component Init

"actions": {
                                        "spreadSheetController": {
                                            "press": "zssarticle.ext.spreadSheetController.spreadSheetController.uploadExcel",
                                            "visible": true,
                                            "enabled": true,
                                            "requiresSelection": false,
                                            "text": "Upload"
                                        }

Manifest

"componentUsages": {
            "spreadsheetImporter": {
                "name": "cc.spreadsheetimporter.v0_31_4"
            }
        },
        "resourceRoots": {
            "cc.spreadsheetimporter.v0_31_4": "./thirdparty/customControl/spreadsheetImporter/v0_31_4"
        },
marianfoo commented 8 months ago

Hi @mainakaich, please send me the metadata.xml if you can to marian@marianzeis.de, that makes it easier to debug. Thanks!

mainakaich commented 8 months ago

Hi @marianfoo ,

I have replied back the metadata.xml to your said email address.

Mainak Aich

On Fri, Feb 2, 2024 at 8:19 AM Marian Zeis @.***> wrote:

Hi @mainakaich https://github.com/mainakaich, please send me the metadata.xml if you can to @.***, that makes it easier to debug. Thanks!

— Reply to this email directly, view it on GitHub https://github.com/spreadsheetimporter/ui5-cc-spreadsheetimporter/issues/484#issuecomment-1923790244, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANCMVGLOPRKSDZGFTLM6C4TYRTRX7AVCNFSM6AAAAABCWSLM7SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRTG44TAMRUGQ . You are receiving this because you were mentioned.Message ID: <spreadsheetimporter/ui5-cc-spreadsheetimporter/issues/484/1923790244@ github.com>

marianfoo commented 8 months ago

Hi @mainakaich please check version 0.31.5 if this fixes it for you

marianfoo commented 8 months ago

Can you check this locally before deployment?

mainakaich commented 8 months ago

Hi @marianfoo

This issue looks fixed in 0.31.5. However, I have 2 apps where I want to use this component. But currently I am not able to do so as I am getting deployment error. I have logged issue #490 for the same.

marianfoo commented 8 months ago

Yeah, I know. That's why I asked 😃 Just because #490 is something to-do with deployment and not the component itself.
I'm closing for now, we can reopen if the deployed version still has errors.