spreadsheetimporter / ui5-cc-spreadsheetimporter

A UI5 Component to integrate a Spreadsheet Upload for UI5 Apps.
https://spreadsheet-importer.com/
Apache License 2.0
75 stars 15 forks source link

button `continue anyay` should be hidden on backend errors #492

Closed marianfoo closed 5 months ago

marianfoo commented 5 months ago

Button should be hidden after the event upload button pressed or event completed

https://github.com/spreadsheetimporter/ui5-cc-spreadsheetimporter/blob/9348694cad5204cfb31188d0db54c9bb0e4fecef/packages/ui5-cc-spreadsheetimporter/src/controller/dialog/SpreadsheetUploadDialog.ts#L212-L214

Mainak - I am referring the 'Continue Anyway' in the perspective of upload(point 2 mentioned below). As I can see there are 2 possibilities when you are showing this dialog.

  1. When user just select the file and then the validation check happens against the records in the UI. If any error occurs, the errors are displayed in the dialog. Here 'Continue Anyway' makes sense where user still wants to proceed despite validation error.
  2. When user clicks on the upload button, then the records are sent to backend and if errors occurred in the backend, they are displayed in the dialog. Here 'Continue Anyway' makes no sense for me as user can't continue anything here. All he can do is to close the dialog. Therefore I was suggesting to remove/hide this button when error occurs during upload.

You´re right, in your case this does not make sense.
In that case the button should be hidden. I´ll fix that.

Originally posted by @marianfoo in https://github.com/spreadsheetimporter/ui5-cc-spreadsheetimporter/issues/491#issuecomment-1941892077