search

spreadsheetimporter / ui5-cc-spreadsheetimporter

A UI5 Component to integrate a Spreadsheet Upload for UI5 Apps.
https://spreadsheet-importer.com/
Apache License 2.0
75 stars 15 forks source link

feat(options): ability to set Message dialog title as well as OData d… #499

Closed NabheetCloud closed 5 months ago

NabheetCloud commented 5 months ago

Hello

We(me and Mainak) have been using the component in one of our apps and its amazing. In one of the requirement where we are returing messages on success or error we wanted the ability to customize the Message as well OData dialog title. As of now it was coming from i18n .

so thought of adding this ability where the developer can enhance any title based on his/her needs. Please me know in case of any clarifications.

Thanks Nabheet

marianfoo commented 5 months ago

Hi Nabheet, thank you for the PR.
I thought about that too that you may want to overwrite any i18n text. That would be better than to have for every text a special config.

Next time you welcome to create a issue first so we can discuss how to implement that (i need to create the template for a feature request)

NabheetCloud commented 5 months ago

yes that will be the icing on the cake if we will give the ability to customize the whole i18n request

marianfoo commented 5 months ago

Hi @NabheetCloud i introduced the option to overwrite i18n text with 0.33.0, see https://docs.spreadsheet-importer.com/pages/Configuration/#i18nmodel

I also added for the OData Messages Dialog a extra i18n key, so you can create a special i18n text only for that dialog https://github.com/spreadsheetimporter/ui5-cc-spreadsheetimporter/blob/de8831f9a30fdcf5b52cc81dcad07c96bb78ebf9/packages/ui5-cc-spreadsheetimporter/src/fragment/ODataMessagesDialog.fragment.xml#L2