search

spreadsheetimporter / ui5-cc-spreadsheetimporter

A UI5 Component to integrate a Spreadsheet Upload for UI5 Apps.
https://spreadsheet-importer.com/
Apache License 2.0
75 stars 15 forks source link

Update GettingStarted.md #524

Closed uxkjaer closed 3 months ago

uxkjaer commented 3 months ago

Added the check on the build script. This took me two hours to find.

marianfoo commented 3 months ago

Hi Jakob, thanks for opening the PR. I'm sorry it took you so much time. i mention it here on the getting started page: https://docs.spreadsheet-importer.com/pages/GettingStarted/#setup-decentralized-deployment 3. Add --all to your build script in the package.json

"scripts": {
  ...
  "build": "ui5 build --config=ui5.yaml --all --clean-dest --dest dist",
  ...
}

Do you mean this?

uxkjaer commented 3 months ago

I guess I need to pay more attention to the doco 😂

On Fri, 12 Apr 2024, 00:09 Marian Zeis, @.***> wrote:

Hi Jakob, thanks for opening the PR. I'm sorry it took you so much time. i mention it here on the getting started page:

https://docs.spreadsheet-importer.com/pages/GettingStarted/#setup-decentralized-deployment

  1. Add --all to your build script in the package.json

"scripts": { ... "build": "ui5 build --config=ui5.yaml --all --clean-dest --dest dist", ... }

Do you mean this?

— Reply to this email directly, view it on GitHub https://github.com/spreadsheetimporter/ui5-cc-spreadsheetimporter/pull/524#issuecomment-2049780629, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB6OUAVIIDMSTTMHRQY6A4LY42KRPAVCNFSM6AAAAABGBYJW4CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBZG44DANRSHE . You are receiving this because you authored the thread.Message ID: <spreadsheetimporter/ui5-cc-spreadsheetimporter/pull/524/c2049780629@ github.com>

marianfoo commented 3 months ago

No worries :)

doco

I see you use ausie slang :D

uxkjaer commented 3 months ago

Haha no one here finishes their senten.

See what I did there 😂

When do we see you in Australia?

On Sat, 13 Apr 2024, 05:38 Marian Zeis, @.***> wrote:

No worries :)

doco

I see you use ausie slang :D

— Reply to this email directly, view it on GitHub https://github.com/spreadsheetimporter/ui5-cc-spreadsheetimporter/pull/524#issuecomment-2052418474, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB6OUATVZA4LBI2LIAAZ2UTY5AZ2RAVCNFSM6AAAAABGBYJW4CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJSGQYTQNBXGQ . You are receiving this because you authored the thread.Message ID: <spreadsheetimporter/ui5-cc-spreadsheetimporter/pull/524/c2052418474@ github.com>

marianfoo commented 3 months ago

Till someone pays for my flight 😁 Would be great to be back some time in the future