Fix when running spreadsheet importer in Fiori elements with multiple tabs

spreadsheetimporter / ui5-cc-spreadsheetimporter

A UI5 Component to integrate a Spreadsheet Upload for UI5 Apps.

https://spreadsheet-importer.com/

Apache License 2.0

75 stars 15 forks source link

Fix when running spreadsheet importer in Fiori elements with multiple tabs #579

Closed lemaiwo closed 3 weeks ago

lemaiwo commented 3 weeks ago

Hi @marianfoo , The upload dialog doesn't close correctly when using the cancel button. It disappears but still blocks the navigation in the fiori elements app. This fixes the problem.

Tested on version 1.96.32

Additional solution could be to provide an event handler to handle the cancel event ourself.

Kr, Wouter

marianfoo commented 3 weeks ago

I have not yet had this problem directly. It sometimes happened during the test, but I couldn't recreate it locally, but that could be the reason. Tests are green so I will merge it and publish it right away. Thank you!

marianfoo commented 3 weeks ago

Fix published with version 1.1.1