search

spreaker / aws-cloud-unmap

External controller to remove terminated EC2 instances from AWS Cloud Map service
MIT License
11 stars 4 forks source link

Setup python package and Docker image publishing #3

Closed pracucci closed 5 years ago

pracucci commented 5 years ago

In this PR I've done the setup to publish the python package and Docker image. I have not tested it yet, cause I would like to get a quick feedback on the overall changes. If they look good, I will publish a first version to test it.

esanchezm commented 5 years ago

Nice work! 👍

pracucci commented 5 years ago

@esanchezm I did some changes since your approval and I would like a re-review:

  1. Upload package with twine
  2. Moved dependencies to setup.py and load them from setup.py in requirements.txt (otherwise we need to add requirements.txt to the package in order for the installation to work correctly)
  3. Added the function run() which is the one referenced in entry_points in setup.py
esanchezm commented 5 years ago

I see you find a different approach for the requirements.txt. Great!