spreaker / aws-cloud-unmap

External controller to remove terminated EC2 instances from AWS Cloud Map service
MIT License
11 stars 4 forks source link

Return true if there are no registered instances in the service #8

Closed esanchezm closed 5 years ago

esanchezm commented 5 years ago

I think in this special case we should return True if there are no registered instances in the service. I think that makes sense considering the nature of this tool is cleanup but it's not an error to clean something empty.

esanchezm commented 5 years ago

Missing tests. Do not merge

esanchezm commented 5 years ago

Sorry I was only running the tests on test_cli.py