spreaker / prometheus-pgbouncer-exporter

Prometheus exporter for PgBouncer
MIT License
104 stars 38 forks source link

show databases return pool size? #2

Closed fonziesherman closed 5 years ago

fonziesherman commented 6 years ago

Hi, this is an excellent exporter. We are looking at alerting if pool usage is getting close to limits of pool size but it doesnt appear this script returns the pool size metric. I may submit a PR if I get the time to work on it, unless this was a feature you already considering adding. Thanks!

pracucci commented 6 years ago

I didn't plan to add it, but it makes sense. If you're willing to submit a PR I will be glad to review and merge it.

On Mon, Mar 19, 2018, 19:45 fonziesherman notifications@github.com wrote:

Hi, this is an excellent exporter. We are looking at alerting if pool usage is getting close to limits of pool size but it doesnt appear this script returns the pool size metric. I may submit a PR if I get the time to work on it, unless this was a feature you already considering adding. Thanks!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/spreaker/prometheus-pgbouncer-exporter/issues/2, or mute the thread https://github.com/notifications/unsubscribe-auth/ABn4EI14tZjDobFQIMsYSZ4zC1rMIBCEks5tf_y8gaJpZM4Sws2n .

fonziesherman commented 6 years ago

Thanks, I will try to get something together asap.

pracucci commented 5 years ago

The metric pgbouncer_databases_database_pool_size is now supported (introduced some time ago by PR #3). I'm going to close this issue.