Closed mbroers closed 6 years ago
Sure thing, standby.
Thanks for the patient feedback. Im not much of a python developer so it helps to be pointed in the right direction. I will make adjustments asap.
whoops disregard this for a moment..
ok, sorry for the noise here you go
Hi, just checking in if there is anything else needed to get this merged or if I missed something?
@mbroers Super sorry for the very late merge. I'm going fix a couple of typos in the README and then I will cut a new version.
@mbroers v. 1.0.0 has been cut. However, pay attention that I've renamed the database
label to backend_database
and the name
label to database
for the three new metrics in this PR, in order to keep consistency with the old metrics (so that you can match metrics by database
label that now has the same meaning).
Looks ok to me in my local environment.