spreaker / prometheus-pgbouncer-exporter

Prometheus exporter for PgBouncer
MIT License
104 stars 38 forks source link

added show databases metrics of interest specifically for alerting #3

Closed mbroers closed 6 years ago

mbroers commented 6 years ago

Looks ok to me in my local environment.

mbroers commented 6 years ago

Sure thing, standby.

mbroers commented 6 years ago

Thanks for the patient feedback. Im not much of a python developer so it helps to be pointed in the right direction. I will make adjustments asap.

mbroers commented 6 years ago

whoops disregard this for a moment..

mbroers commented 6 years ago

ok, sorry for the noise here you go

mbroers commented 6 years ago

Hi, just checking in if there is anything else needed to get this merged or if I missed something?

pracucci commented 6 years ago

@mbroers Super sorry for the very late merge. I'm going fix a couple of typos in the README and then I will cut a new version.

pracucci commented 6 years ago

@mbroers v. 1.0.0 has been cut. However, pay attention that I've renamed the database label to backend_database and the name label to database for the three new metrics in this PR, in order to keep consistency with the old metrics (so that you can match metrics by database label that now has the same meaning).