search

spree-contrib-variants / spree_flexi_variants

Spree extension to create product variants as-needed
BSD 3-Clause "New" or "Revised" License
5 stars 2 forks source link

Use spree_product_customizations instead? #1

Open sfcgeorge opened 9 years ago

sfcgeorge commented 9 years ago

I've forked spree_product_customizations into the org as well. It's a newer version of spree_flexi_variants from the original author, but only the customizations half, not the options bit. Personally that's all I need so I think I'll be switching over and maintaining it. Any objections? Thoughts?

jsqu99 commented 9 years ago

i don't recollect where i left off w/ that extension, but i looked at the readme and it said it wasn't yet ready...so be careful. It should've been a separate extension initially

sfcgeorge commented 9 years ago

I saw the note in the Readme but it seems ok. I was updating the old extension, and in doing so realised how many monkeypatches to Spree models there are, then I saw there's a new hook in Spree for doing it... and found you were the one who added it for this new extension! So it seemed silly basically turning the old extension into the new one. The old one is so complicated and I always found the options bit confusing, others seem to mainly be using the customizations too. So I'm happy to continue with the new extension and we'll see how it goes. I've got it to run in Spree 3 at least and updated some of the admin UI, no idea yet if it functions though.

alexgirdler commented 9 years ago

I would suggest if we do switch to the product customisations to also split the other half of flexi_variants into it's own separate plugin. A few of the things we have in our product pipeline would greatly benefit from having the ad-hoc options. I would be up for ripping that from flexi_variants and maintaining it.

sfcgeorge commented 9 years ago

That would be fantastic! Hopefully 2 simpler gems would be easier to maintain than the one old big one. And it should make it clearer which code is needed for what as there's a lot of monkeypatch spaghetti code. Maybe simpler code would encourage more contributions too, we'll see.

I've added a Gitter chat too, so feel free to ping with any ideas.