search

spree-contrib / better_spree_paypal_express

A better Spree PayPal Express Extension.
http://guides.spreecommerce.org
BSD 3-Clause "New" or "Revised" License
110 stars 269 forks source link

Fixes specs broken by Paypal payment flow changes #126

Closed fredjean closed 9 years ago

fredjean commented 9 years ago

This should bring the specs back to green.

JDutil commented 9 years ago

Theres still 1 failing but better than before.

fredjean commented 9 years ago

Which one? I did get quite a few cases where Paypal would throw a generic server error. Repeating the failing spec would then work.

JDutil commented 9 years ago 
Failures:

  1) PayPal with 'Sole' solution type passes user details to PayPal
  Failure/Error: within("#loginForm") do
  Capybara::ElementNotFound:
    Unable to find css "#loginForm"
  HTML screenshot: /Users/JDutil/Code/better_spree_paypal_express/spec/dummy/tmp/capybara/screenshot_2014-10-01-21-22-02.424.html
  Image screenshot: /Users/JDutil/Code/better_spree_paypal_express/spec/dummy/tmp/capybara/screenshot_2014-10-01-21-22-02.424.png
  # ./spec/features/paypal_spec.rb:39:in `login_to_paypal'
  # ./spec/features/paypal_spec.rb:93:in `block (3 levels) in <top (required)>'

Finished in 2 minutes 11.9 seconds
15 examples, 1 failure

Failed examples:

rspec ./spec/features/paypal_spec.rb:78 # PayPal with 'Sole' solution type passes user details to PayPal
fredjean commented 9 years ago

I'll look into it and submit a follow up PR if I find a fix.

Fred

On Wednesday, October 1, 2014, Jeff Dutil notifications@github.com wrote:

Failures:

1) PayPal with 'Sole' solution type passes user details to PayPal Failure/Error: within("#loginForm") do Capybara::ElementNotFound: Unable to find css "#loginForm" HTML screenshot: /Users/JDutil/Code/better_spree_paypal_express/spec/dummy/tmp/capybara/screenshot_2014-10-01-21-22-02.424.html Image screenshot: /Users/JDutil/Code/better_spree_paypal_express/spec/dummy/tmp/capybara/screenshot_2014-10-01-21-22-02.424.png

./spec/features/paypal_spec.rb:39:in `login_to_paypal'

./spec/features/paypal_spec.rb:93:in`block (3 levels) in <top (required)>'

Finished in 2 minutes 11.9 seconds 15 examples, 1 failure

Failed examples:

rspec ./spec/features/paypal_spec.rb:78 # PayPal with 'Sole' solution type passes user details to PayPal

— Reply to this email directly or view it on GitHub https://github.com/spree-contrib/better_spree_paypal_express/pull/126#issuecomment-57567510 .