search

spree-contrib / better_spree_paypal_express

A better Spree PayPal Express Extension.
http://guides.spreecommerce.org
BSD 3-Clause "New" or "Revised" License
110 stars 269 forks source link

Update flash message on completed checkout. #131

Closed deftOfCenter closed 9 years ago

deftOfCenter commented 9 years ago

This was updated beginning in 2-3. The adjustment fixes the default google analytics ecommerce tracking setup, and thank you message. This change was updated in this spreecommerce commit https://github.com/spree/spree/commit/a1678bcfe124e44b7658088f52c5717468735137

deftOfCenter commented 9 years ago

I know my commit is way similar to the previous pull request, but I matched the changes from the original commit in spree, since leaving the line, flash[:commerce_tracking] = 'nothing special', leaves a flash message on the summary page of checkout, which unsurprisingly says, nothing special.

jonmast commented 9 years ago

Is there a reason this hasn't been merged?

JDutil commented 9 years ago

This project needs new maintainers.

jonmast commented 9 years ago

I would be interested in helping. What are the qualifications?

JDutil commented 9 years ago

Familiarity w/spree & this extension. Ensuring specs are passing and provided in new PRs, and knowing how to use git cherry-pick & conflict resolution for merges/rebases.

alepore commented 9 years ago

thi code was merged from another PR, thanks