search

spree-contrib / better_spree_paypal_express

A better Spree PayPal Express Extension.
http://guides.spreecommerce.org
BSD 3-Clause "New" or "Revised" License
110 stars 269 forks source link

red specs #134

Closed alepore closed 9 years ago

alepore commented 9 years ago

Hi, i'm preparing some PR but i'm getting many spec errors with the current code. saw some recent work by @fredjean so i'm asking if specs actually need to be fixed on all branches or maybe is a problem of mine.

thanks

15 examples, 9 failures

Failed examples:

rspec ./spec/features/paypal_spec.rb:51 # PayPal pays for an order successfully
rspec ./spec/features/paypal_spec.rb:104 # PayPal includes adjustments in PayPal summary
rspec ./spec/features/paypal_spec.rb:78 # PayPal with 'Sole' solution type passes user details to PayPal
rspec ./spec/features/paypal_spec.rb:156 # PayPal line item adjustments includes line item adjustments in PayPal summary
rspec ./spec/features/paypal_spec.rb:197 # PayPal will skip $0 items
rspec ./spec/features/paypal_spec.rb:249 # PayPal can process an order with $0 item total
rspec ./spec/features/paypal_spec.rb:331 # PayPal as an admin refunding payments can refund payments fully
rspec ./spec/features/paypal_spec.rb:348 # PayPal as an admin refunding payments can refund payments partially
rspec ./spec/features/paypal_spec.rb:363 # PayPal as an admin refunding payments errors when given an invalid refund amount
futhr commented 9 years ago

Hi @alepore, focus on the branch you actually use, that pr will be very helpful to fix the rest.