search

spree-contrib / better_spree_paypal_express

A better Spree PayPal Express Extension.
http://guides.spreecommerce.org
BSD 3-Clause "New" or "Revised" License
110 stars 269 forks source link

Important fixes for VAT-included stores [2-3-stable] #139

Open alepore opened 9 years ago

alepore commented 9 years ago

This PR enable paypal payments for stores with VAT-included prices (very common in the EU) and should finally solve #129 and #17.

The first fix was already included in 2-2-stable, this just adds a regression spec.

The second one it's a kind of workaround because paypal does not accept negative taxes amounts. But this is very important because on Spree we have negative taxes when a country without VAT buys from a VAT-included store, like in this example: screen shot 2014-11-29 at 13 36 31

This is also including all the commits from https://github.com/spree-contrib/better_spree_paypal_express/pull/138 to get green specs.

alepore commented 9 years ago

@peterfealey @paulgroves @ouechtasvu @Hates @IrvinFan please take a look

pusewicz commented 9 years ago

ping @JDutil @peterfealey @paulgroves @ouechtasvu @Hates @IrvinFan

pusewicz commented 9 years ago

This should also be merged into master

alepore commented 9 years ago

in the end i didn't use this code but i think it's still relevant. i'm just asking for some feedback/sanity checking as it's pretty complex/critical stuff :)

JDutil commented 9 years ago

I don't use or care about paypal at all. The specs fail terribly on this extension for me as well so I'm not going to be touching anything here until someone fixes them. The changes in the works over at https://github.com/spree/spree/pull/6227 may be relevant to fixing this issue though.