spree-contrib / better_spree_paypal_express

A better Spree PayPal Express Extension.

http://guides.spreecommerce.org

BSD 3-Clause "New" or "Revised" License

110 stars 270 forks source link

fix current_symbol_position is no long available in the spree #174

Closed simontseng closed 9 years ago

simontseng commented 9 years ago

using Money::Currency to obtain currency symbol instead of creating an money object of value 1
using Money::Currency’s symbol_first property to determine the order of symbol and value
change style to use bootstrap since it is default in 3.0

simontseng commented 9 years ago

trying to fix

170

however looks like i am fixing one incompatibility issues and making 2 improvement, please help to comment and let me know if i should break the changes into 3 commits

simontseng commented 9 years ago

please advise if there is any test involved?

moholtzberg commented 9 years ago

has this commit been pulled in yet?

alepore commented 9 years ago

:+1: thanks! most integration tests are currently disabled because no one wants to battle with paypal UI changes, but any help is appreciated