spree-contrib / better_spree_paypal_express

A better Spree PayPal Express Extension.
http://guides.spreecommerce.org
BSD 3-Clause "New" or "Revised" License
110 stars 270 forks source link

API endpoints, Migrate PR #168 from 2-4-stable to 3-0-stable #177

Open givanse opened 9 years ago

givanse commented 9 years ago

Migrate PR #168 from 2-4-stable to 3-0-stable.

I had 1 local failure, but I don't think is related to any of the PR changes. See: https://github.com/spree-contrib/better_spree_paypal_express/issues/176 Maybe Travis results will come up fine.

givanse commented 9 years ago

Travis fails with the same error reported in https://github.com/spree-contrib/better_spree_paypal_express/issues/176, at least is consistent.

The failure is not related at all with the changes of this PR.

williscool commented 9 years ago

@MisinformedDNA

alexw23 commented 8 years ago

What's the latest on this @givanse ?

alexw23 commented 8 years ago

We should look at taking this logic for the API instead and putting it along with https://github.com/spree/spree_gateway/issues/232

givanse commented 8 years ago

The PR is complete, but its blocked by #176

lynndylanhurley commented 8 years ago

@givanse - I'm trying to use this code in my project. Can you point me to documentation on how the API requests / responses should look for this PR?

Something like this walkthrough would be great: https://github.com/spree-contrib/spree_api_examples/blob/master/examples/checkout/walkthrough.rb

givanse commented 8 years ago

I never got this branch to work (see #176). I went with 2-4-stable.

When I was working with this gem I was building an Ember app, the addon I used for it is here: https://github.com/aethermx/spree-ember-paypal-express That repo should give you an idea of how the frontend is talking to the backend. It feels like this was ages ago. If that addon is of no help, feel free to ping me again.