spree-contrib / better_spree_paypal_express

A better Spree PayPal Express Extension.
http://guides.spreecommerce.org
BSD 3-Clause "New" or "Revised" License
110 stars 270 forks source link

No Handling for PayPal funding error 10486 #179

Open mleglise opened 8 years ago

mleglise commented 8 years ago

When a user finishes on PayPal, and clicks "Pay Now" to redirect them back to Spree, then spree/gateway/pay_pal_express.rb calls do_express_checkout_payment and then pp_response.success?

If the user does not have enough money in their funding source to pay for the order, PayPal returns error 10486. The user is supposed to be redirected back to PayPal to resolve the issue with funding their purchase. Currently, the user gets dumped to the Spree store's homepage and left with no indication of anything working or failing. Their order is left in the "payment" state with a failed PayPal transaction.

https://developer.paypal.com/docs/classic/express-checkout/ht_ec_fundingfailure10486/