spree-contrib / better_spree_paypal_express

A better Spree PayPal Express Extension.
http://guides.spreecommerce.org
BSD 3-Clause "New" or "Revised" License
110 stars 270 forks source link

Fix feature spec #200

Open essa opened 6 years ago

essa commented 6 years ago

This fixes the broken feature spec, spec/features/paypal_spec.rb.

I found this spec fails and was skipped on other stable branches. I need to customize this gem for our site so I fixed the specs.

Following changes were needed to run it against current PayPal site.

  1. Versionfile was needed to generate a test app by rake test_app
  2. Need to specify version of rake
  3. I Changed many queries for HTML elements to match the current PayPal site
  4. I inserted many sleeps for waiting PayPal client side scripts to be ready

Here's difficult or mysterious parts for adjusting test script for PayPal site.

I think this is used for master or other stable branches but I made a PR for 1-3-stable which I'm using now.