search

spree-contrib / better_spree_paypal_express

A better Spree PayPal Express Extension.
http://guides.spreecommerce.org
BSD 3-Clause "New" or "Revised" License
110 stars 269 forks source link

Incompatible with Rails 4 because 'attr_accessible' #23

Closed francesco-carrella closed 11 years ago

francesco-carrella commented 11 years ago

Hi, as I understand, the v 2.1 of Spree is totally based on Rails 4. So this extension, in the branch 2.1-stable, shouldn't use rails4 deprecated 'attr_accessible', is it right?

=> Booting Puma
=> Rails 4.0.0 application starting in development on http://0.0.0.0:3000
=> Run `rails server -h` for more startup options
=> Ctrl-C to shutdown server
Exiting
/usr/local/Cellar/ruby/2.0.0-p247/lib/ruby/gems/2.0.0/gems/activemodel-4.0.0/lib/active_model/deprecated_mass_assignment_security.rb:14:in `attr_accessible': `attr_accessible` is extracted out of Rails into a gem. Please use new recommended protection model for params(strong_parameters) or add `protected_attributes` to your Gemfile to use old one. (RuntimeError)
    from /usr/local/lib/ruby/gems/2.0.0/bundler/gems/better_spree_paypal_express-11c747cac357/app/models/spree/gateway/pay_pal_express.rb:9:in `<class:PayPalExpress>'
    from /usr/local/lib/ruby/gems/2.0.0/bundler/gems/better_spree_paypal_express-11c747cac357/app/models/spree/gateway/pay_pal_express.rb:3:in `<module:Spree>'
    from /usr/local/lib/ruby/gems/2.0.0/bundler/gems/better_spree_paypal_express-11c747cac357/app/models/spree/gateway/pay_pal_express.rb:2:in `<top (required)>'
...
radar commented 11 years ago

This does indeed seem to be an issue with the extension. I will fix it up tomorrow. Sorry about that.

On Sun, Sep 22, 2013 at 11:10 AM, jbardrof notifications@github.com wrote:

I don't believe it's spree directly, it's devise. Devise still hasn't updated to fix that.

Reply to this email directly or view it on GitHub: https://github.com/radar/better_spree_paypal_express/issues/23#issuecomment-24873898

radar commented 11 years ago

This issue has now been fixed.

francesco-carrella commented 11 years ago

Tnx!

It's working now up to post payment redirection, then I have this problem: https://github.com/radar/better_spree_paypal_express/issues/24