search

spree-contrib / better_spree_paypal_express

A better Spree PayPal Express Extension.
http://guides.spreecommerce.org
BSD 3-Clause "New" or "Revised" License
110 stars 269 forks source link

don't error out, if address page was missing due to customized checkout flow #72

Closed skatkov closed 10 years ago

skatkov commented 10 years ago

In case of customized checkout flow, if address page was missing - error will show. But not anymore.

skatkov commented 10 years ago

@radar any problems with commit?

radar commented 10 years ago

@skatkov No problems, I've just been ridiculously busy on the Spree 2.2 release, SpreeConf and conferencing in the US. Sorry!

Do you have a link to an explanation of the different payment methods "Mark" and "Sole"? I am not sure I understand why address is required in one or the other. If you could provide that to me then that would be great.

I will reply much quicker next time :)

skatkov commented 10 years ago

@radar According to a readme provided by this gem (https://github.com/spree-contrib/better_spree_paypal_express)

payment_method.preferred_solution_type = "Mark"
# or
payment_method.preferred_solution_type = "Sole"
"Mark" if you do want users to have a paypal account, "Sole" otherwise.

If preferred_solution is 'Mark' then paypal already have address information and address fields becomes irrelevant.

skatkov commented 10 years ago

@radar sorry for bugging you. Is everything ok?:) can you merge ?:)

radar commented 10 years ago

Sorry mate, I've been busy. I will look at this next Tuesday.

On Fri, Apr 11, 2014 at 2:57 AM, SK notifications@github.com wrote:

@radar sorry for bugging you. Is everything ok?:) can you merge ?:)

Reply to this email directly or view it on GitHub: https://github.com/spree-contrib/better_spree_paypal_express/pull/72#issuecomment-40110227

radar commented 10 years ago

Thanks @skatkov. I've added this to master, 2-2-stable, 2-1-stable, 2-0-stable and 1-3-stable.