search

spree-contrib / spree-multi-domain

Multiple Spree stores on different domains - single unified backed for processing orders
https://guides.spreecommerce.org
194 stars 191 forks source link

wrong super call #150

Open blset opened 8 years ago

blset commented 7 years ago

The sha1 is given by deface itself in the log in development mode

the message is something like :

this override has no original consider adding orignal => « the sha1 »

Le 10 févr. 2017 à 08:43, Paarth notifications@github.com a écrit :

@ParthBarot-BoTreeConsulting commented on this pull request.

In app/overrides/decorate_admin_products_form.rb https://github.com/spree-contrib/spree-multi-domain/pull/150#pullrequestreview-21192835:

@@ -1,6 +1,7 @@ Deface::Override.new( virtual_path: "spree/admin/products/_form", name: "multi_domain_admin_product_form_meta",

  • :original => '2724f51d519589f73401abeae8f8e05d9dae99c4', @blset https://github.com/blset Just curious how can I generate this original SHA1 value, from which string?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/spree-contrib/spree-multi-domain/pull/150#pullrequestreview-21192835, or mute the thread https://github.com/notifications/unsubscribe-auth/AAio_qHd4m8PxHcG8uoDoEYFAx75pUWpks5rbBUHgaJpZM4Iv8Ek.

ParthBarot-BoTreeConsulting commented 7 years ago

@blset Thanks for your quick reply. So first I should remove the existing original (As I am modifying an existing deface in a gem), and then run the server again to see the new sha1 it suggest in the log, and then put that new value in the original attribute. Correct?

Thanks

blset commented 7 years ago

yes exactly

Le 10 févr. 2017 à 10:38, Paarth notifications@github.com a écrit :

@blset https://github.com/blset Thanks for your quick reply. So first I should remove the existing original (As I am modifying an existing deface in a gem), and then run the server again to see the new sha1 it suggest in the log, and then put that new value in the original attribute. Correct?

Thanks

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/spree-contrib/spree-multi-domain/pull/150#issuecomment-278899250, or mute the thread https://github.com/notifications/unsubscribe-auth/AAio_sCs-Y5w0EZzqKYQxN1SV_MCN9gkks5rbDAvgaJpZM4Iv8Ek.