search

spree-contrib / spree_active_shipping

Spree integration for Shopify's active_shipping gem.
http://guides.spreecommerce.org
134 stars 207 forks source link

Fix USPS issues #196

Closed IrvinFan closed 9 years ago

IrvinFan commented 9 years ago

The usps shipping calculators in this gem seem to be out of date. This PR does the following:

  1. Add different service_code prefix for domestic and international rates because the code returned from usps API is not mutally exclusive between domestic and international rates. e.g. service_code "1" is priority mail for domestic and express mail for international. With the prefix we can now distinguish them.
  2. Add two new shipping rates: GlobalExpressGuaranteed and StandardPost
  3. Bug fix (check AVAILABLE_COUNTRIES instead of undefined WEIGHT_LIMITS in a few places)
  4. Bring it up to Rails 4.0 and ruby 1.9.3
  5. Fix broken rspec
  6. Code cleanup
JDutil commented 9 years ago

We are interested in finding other developers willing to help maintain these extensions. Would you be interested in commit access?

IrvinFan commented 9 years ago

Sure. I'm interested in commit access.

JDutil commented 9 years ago

Merged up to master and sent invite.