search

spree-contrib / spree_active_shipping

Spree integration for Shopify's active_shipping gem.
http://guides.spreecommerce.org
134 stars 207 forks source link

1 0 active shipping upgrade #213

Closed jspizziri closed 9 years ago

jspizziri commented 9 years ago

Upgrade active_shipping overrides to be compatible with active_shipping >= 1.0.0.pre1

jspizziri commented 9 years ago

Alright, so this PR will at the very least fix the bug where active_shipping crashes on checkout. I think I maintained all the logic that was in the prior version; however its hard to say because so much dev has been going on with active_shipping.

I'm guessing there are going to be more issues with this until they release a stable version that can be locked in.

Also, if you could pull this through to 3-0-stable that would be baller.

jspizziri commented 9 years ago

@JDutil I know you're a busy guy, but master and 3-0-stable are completely toast until this gets merged in.

JDutil commented 9 years ago

Thanks. I don't use this extension at all so unless I'm mentioned on it I won't receive notifications. As you're well aware this extension needs additional maintainers since you're the only one stepping up to the plate here I could provide commit access if you want.

jspizziri commented 9 years ago

No problem.

Sure, I'll take on some of the maintenance responsibilities. This is a super important extension for a continued broad acceptance of spree IMO, so I'd hate to see it degrade.

JDutil commented 9 years ago

@jspizziri I've sent an invite. I agree it's an important extension, but surprisingly relatively few people actually use it. More important surprisingly few people actually care about maintaining it. For continued broad acceptance of Spree we need a thriving community of contributors maintaining the projects they find important.

jspizziri commented 9 years ago

:+1: I agree. I've recently been on a rampage to get several projects upgraded to 3.0.