search

spree-contrib / spree_digital

A Spree extension to enable downloadable products
http://spreecommerce.org
MIT License
117 stars 97 forks source link

update gemspec to match Versionfile (spree 3.1) #93

Closed tomash closed 9 years ago

tomash commented 9 years ago

According to Versionfile, master branch is compatible with spree 3.1 but gemspec was still set at ~> 3.0.0 and Gemfile pointed to spree/spree, branch: '3-0-stable'

halo commented 9 years ago

Hi @tomash Sorry for not getting back at you earlier. I'm not using the spree_digital in a recent spree version, so it's hard for me to merge in pull requests by just looking at the code. In this case I think I'll just go ahead and merge, because your commit looks reasonable to me. And if things go wrong, people can still complain and we'll revert it :)

I'm curious, are you developing locally in spree master and are using spree_digital there among others?

tomash commented 9 years ago

Yes I do, I'm developing a store for selling digital goods (ebooks to begin with) and decided to upgrade spree/spree in Gemfile (last time I went with spree's master it was a mere few commits beyond 3.0 stable).

I can guarantee I'll make issues as soon as I stumble upon ones in spree_digital for current master / 3.1 :)

halo commented 9 years ago

Good luck and thank you :)