search

spree-contrib / spree_drop_ship

Spree Drop Shipping Extension
BSD 3-Clause "New" or "Revised" License
104 stars 120 forks source link

Missing method for :supplier_id #2

Closed rterbush closed 11 years ago

rterbush commented 11 years ago

Request for /admin/products/.../edit errors out with missing method: :supplier_id

Not sure if this is the right solution but should highlight the problem.

JDutil commented 11 years ago

This has been fixed with ac988d47b485a860821be47c01310f692717d50b please note you'll need to:

bundle update spree_drop_ship
bundle exec rake railties:install:migrations
bundle exec rake db:migrate

In order to upgrade.

Also please note that the migration wipes out the spree_supplier_products table altogether now. From our previous conversations it sounded like you wanted extra data to be stored in that table so you may need to alter the migration or simply add the table back in with your own custom logic after. It really doesn't make any sense for this extension to have the join table that was originally in the repo before the rewrite. products should belong directly to the supplier rather than having one supplier to simplify the code.

rterbush commented 11 years ago

Thanks Jeff, looks like some great work.

Sorry to have posted both comment and issue on the github. Realized after posting the comment that I should just create an issue for you.

I'll have a look at it myself today.

Randy

On Sat, Feb 16, 2013 at 3:03 AM, Jeff Dutil notifications@github.comwrote:

This has been fixed with ac988d4https://github.com/jdutil/spree_drop_ship/commit/ac988d47b485a860821be47c01310f692717d50bplease note you'll need to:

bundle update spree_drop_ship bundle exec rake railties:install:migrations bundle exec rake db:migrate

In order to upgrade.

Also please note that the migration wipes out the spree_supplier_products table altogether now. From our previous conversations it sounded like you wanted extra data to be stored in that table so you may need to alter the migration or simply add the table back in with your own custom logic after. It really doesn't make any sense for this extension to have the join table that was originally in the repo before the rewrite. products should belong directly to the supplier rather than having one supplier to simplify the code.

— Reply to this email directly or view it on GitHubhttps://github.com/jdutil/spree_drop_ship/pull/2#issuecomment-13647547.