search

spree-contrib / spree_drop_ship

Spree Drop Shipping Extension
BSD 3-Clause "New" or "Revised" License
104 stars 120 forks source link

rails g spree_drop_ship:install blows up on Spree 2.1, Ruby 2 #28

Closed pusewicz closed 10 years ago

pusewicz commented 11 years ago 
/Users/piotr/.rbenv/versions/2.0.0-p247/lib/ruby/gems/2.0.0/gems/deface-1.0.0.rc4/lib/deface/dsl/loader.rb:30:in `instance_eval': (eval):3: unterminated string meets end of file (SyntaxError)
JDutil commented 11 years ago

This extension currently only supports spree 2.0.x. Pull requests are welcome if you would like to upgrade it.

pusewicz commented 11 years ago

Yeah, no problem. But I would need some guidance as I'm new to both Spree and your extension and I'm not sure what's wrong really ;)

JDutil commented 11 years ago

Can you please provide the full stack trace. All I can tell from that line is that deface is where the error is occurring. When debugging errors like these provide the full stack trace, and then look for the last line occurring within this extensions code to help track down where exactly things are going wrong.

pusewicz commented 11 years ago

So I managed to diagnose that and it's deface being a problem. I created a test case and an issue https://github.com/spree/deface/issues/110

jordanfowler commented 11 years ago

I'd also like to help out with this project and spree_marketplace. I'm getting familiarized with the codebases in general and will contribute all I can. Some guidance would certainly be welcome.

JDutil commented 10 years ago

Hey guys we've figure out and implemented a workaround to the deface error during installation on Spree 2.1.x which you can track progress on here: https://github.com/spree/deface/issues/110

Your now met with Rails 4 errors, but those should be much easier for you guys to find information on to fix. If any of you get things running on Rails 4 & Spree 2.1.x please send PRs.

JDutil commented 10 years ago

Should be able to get everything installed and running now on Spree 2.1.x with the latest updates, but there may still be Rails 4 issues to cleanup.