search

spree-contrib / spree_drop_ship

Spree Drop Shipping Extension
BSD 3-Clause "New" or "Revised" License
104 stars 120 forks source link

Closer to Spree 2.1.2 compatibiliy #32

Closed mdundas closed 10 years ago

mdundas commented 10 years ago

Works well, except for the links on the Supplier view. I included a todo next to the broken links. Notice the bumped version of friendly_id.

JDutil commented 10 years ago

Thanks. Do you not get a FriendlyId error when using in your application? Trying to run the specs I receivE: uninitialized constant FriendlyId::ActiveRecord

mdundas commented 10 years ago

Did you see the line i changed in the Gemspec? Maybe it didn't get picked up?

s.add_dependency 'friendly_id', '~> 5.0.0'

mdundas commented 10 years ago

You'll also need that line in your Gemfile... thats probably what the problem is. You could add it to your documentation but since its a requirement of Spree/Rails and not drop_ship i don't think its necessary.

JDutil commented 10 years ago

It's required for this extension not Spree. It shouldn't need to be added to your Gemfile since it's been added to the gemspec and required here: https://github.com/jdutil/spree_drop_ship/blob/master/lib/spree_drop_ship.rb#L2

but the call to require it is what causes the error.

JDutil commented 10 years ago

I've merged your work but It's still broken.

mdundas commented 10 years ago

I have some time, i'll look into adding support for strong parameters...