search

spree-contrib / spree_editor

Rich text editor for Spree with Image and File uploading in-place.
http://guides.spreecommerce.org
BSD 3-Clause "New" or "Revised" License
112 stars 183 forks source link

Deleted old tinymce assets #19

Closed patrickmcelwee closed 12 years ago

patrickmcelwee commented 12 years ago

These legacy assets have been deleted in the master branch, but not in the 0-70-x branch for those of us not yet upgraded. :-) Plus, there is a UTF-8 error in one of these files during pre-compilation that this will fix.

DavidOliver commented 12 years ago

I was getting the UTF-8 error when precompiling. Removing the spellchecker extension directory fixed it.

patrickmcelwee commented 12 years ago

Yes, I can see that. I was recommending deleting all the tinymce files. Given the move toward using the tinymce-rails gem, they seem to be redundant.

BUT, perhaps the move to the tinymce-rails gem should only be for version 1.0, in which case your other pull request would fix 0.70 without silently requiring everyone to install an additional gem. I'll leave this pull request open and leave it to romul to decide on the best strategy, but I lean toward your fix.