spree-contrib / spree_editor

Rich text editor for Spree with Image and File uploading in-place.
http://guides.spreecommerce.org
BSD 3-Clause "New" or "Revised" License
112 stars 183 forks source link

Publish configuration instance #29

Closed felixbuenemann closed 11 years ago

felixbuenemann commented 11 years ago

I think spree_editor should publish an instance of it's configuration under Spree::Editor::Config, similar to spree or other plugins like spree_address_book.

That way we could easily add configuration from an initializer:

Spree::Editor::Config.tap do |config|
  config.ids << " news_teaser news_body"
end

See https://github.com/romul/spree_address_book/blob/master/lib/spree_address_book.rb for an example.

JDutil commented 11 years ago

I think that is a good idea. Could you work up the pull request for it?

felixbuenemann commented 11 years ago

Yes, I think I'll have time for that next week.

JDutil commented 11 years ago

I've made an update to allow this which is described here: https://github.com/spree/spree_editor#configuration

Note that it is SpreeEditor::Config NOT Spree::Editor::Config as you suggested.

felixbuenemann commented 11 years ago

Thanks! I was kinda busy last week, so I didn't get around to doing a PR.