search

spree-contrib / spree_editor

Rich text editor for Spree with Image and File uploading in-place.
http://guides.spreecommerce.org
BSD 3-Clause "New" or "Revised" License
112 stars 183 forks source link

ckeditor_assets directory created in root of public directory making Capistrano shared files annoying. #43

Closed robertmassaioli closed 11 years ago

robertmassaioli commented 11 years ago

I made the mistake of forgetting to add ckeditor_assets to the list of shared directories in Capistrano between deployments and, as a result, some of our images went missing after I performed a deployment thanks to the fact that they did not exist in the new directory.

My proposed solution is that the ckeditor_assets directory be created under public/spree, or maybe even public/spree/editor so that we can clearly place it in a known location and people that already save the 'spree' directory into the shared directory with capistrano do not forget to include this one too.

Solving this issue in a nice way should avoid deployment pain for many users.

JDutil commented 11 years ago

If you'd like to submit a PR for this I would like it, but this is a general deployment configuration step to do more than it really is an issue for this project.

robertmassaioli commented 11 years ago

Hmm, it is an issue of the project that it is more difficult than it needs to be in order to manage it's deployment successfully. But I guess this is a matter of opinion.

JDutil commented 11 years ago

I'm not against the idea, but I'm not going to be spending time on it as it's a deployment configuration.

If you could please submit a pull request making the desired change I will look into it then.

robertmassaioli commented 11 years ago

Okay sweet, that is no problem, I was not arguing for you (or anybody) to do it right now but rather that it was important. It is not my highest priority right now either but when I get to it on my backlog then you will get a pull request.