search

spree-contrib / spree_fancy

SpreeFancy is a responsive theme for Spree Commerce.
http://guides.spreecommerce.org
BSD 3-Clause "New" or "Revised" License
86 stars 187 forks source link

Product titles lost with caching and i18n in 2.4 #133

Open burlap opened 9 years ago

burlap commented 9 years ago

I discovered the issue in production, but enabling caching in development also triggers the bug: after switching locale back and forth, the product title on a product page disappears. In Spree without fancy it works fine. Looks like it's related to moving the title to subheader.

Tested also with clean 2.4 stable.

crystalized commented 9 years ago

I'm having the same issue in production mode or in development mode with caching enabled. This issue is happening in a fresh clean install of spree_fancy. The only way to restore the title is to delete the cache. But the title immediately goes away again once you've refreshed.

config.action_controller.perform_caching = false I've temporarily disabled the cache in production mode since I don't know how to fix it.

rsempe commented 9 years ago

+1 Same issue here

burlap commented 9 years ago

It's a Rails issue with content_for, try using this gist: https://gist.github.com/dignoe/2485272 (It works for me, but I haven't tested it thoroughly)

crystalized commented 9 years ago

The hack is working me and I haven't noticed any issues so far. Thank you for posting this, @burlap!