search

spree-contrib / spree_globalize

Adds support for model translations (multi-language stores) using Globalize gem
https://spreecommerce.org
BSD 3-Clause "New" or "Revised" License
24 stars 101 forks source link

Migration to mobility gem - spree_mobility #100

Open mrbrdo opened 2 years ago

mrbrdo commented 2 years ago

Hey, this is not really an "issue" but I wanted to let you know that I forked this project and switched to the mobility gem, which is recommended by globalize authors as the successor to globalize (not actively developed anymore).

Mobility works very, very similarly to globalize, but there are a few subtleties that had to be updated. All the database stuff remains the same so it's a drop-in replacement. I also fixed some bugs and I plan to update the admin views a bit because it bothers me that product description has no WYSIWYG editor, for example. I will switch to it in production next week.

If you want you could add a note about this gem in the readme, spree guides or elsewhere, as an alternative to spree_globalize.

https://github.com/mrbrdo/spree_mobility

Also just want to point out that spree itself still includes a few lines of code pertaining to SpreeGlobalize, which should really be extracted into spree_globalize, for example like I've done for SpreeMobility: https://github.com/mrbrdo/spree_mobility/commit/7d81cb27eb94c759e811fa238597c73c536d968c

Regards, Jan

Kulgar commented 2 years ago

Wow, thank you so much for this gem and all the work! <3 I'll switch to your gem right away :-)

mrbrdo commented 2 years ago

Thanks! I think I did some updates in master, so I also pushed a v1.1 of the gem now. I am using it in production, so far without problems (as in Readme, I added fallback locales especially for admin to not have issues with empty translations on secondary locales). Also as noted, need to use my version of friendly_id-mobility, until the maintainer merges those bugfixes. I also am using some fixes for mobility (https://github.com/mrbrdo/mobility/tree/mrbrdo) but I think they may not be needed for everyone, it has to do mostly with subclasses and fallbacks (although it shouldn't hurt to have these).

Please let me know if you have any issues, since I only tested it with my app. Will be glad to have any feedback.

Kulgar commented 2 years ago

@mrbrdo : so far, so good, it works like a charm (except for the issue I posted on your project)