search

spree-contrib / spree_mail_settings

Mail setting functionality extracted from Spree.
http://guides.spreecommerce.org
BSD 3-Clause "New" or "Revised" License
28 stars 152 forks source link

Add mails_from preference #12

Closed joseramonc closed 9 years ago

joseramonc commented 9 years ago

As noted in #9, mails_from don't have a default so it raises an exception when you install from scratch and go to mail_preferences settings.

This pull request adds the default preference.

sepastian commented 9 years ago

:+1:

Please merge!

futhr commented 9 years ago

@joseramonc @sepastian It has been merged into master branch, but it actually use Spree::Store.mail_from_address and the preference :mails_from seems just to clear errors but is ignored and do not override anything. I think this need some additional PR and testing so it play correct with multi-store features.