Removes a lot of logic out of the controller and into model per https://...

spree-contrib / spree_multi_currency

Provides UI to allow configuring multiple currencies in Spree.

http://guides.spreecommerce.org

BSD 3-Clause "New" or "Revised" License

41 stars 117 forks source link

Removes a lot of logic out of the controller and into model per https://... #18

Closed jsqu99 closed 10 years ago

jsqu99 commented 10 years ago

...github.com/spree/spree/pull/4331

This PR is pending review of https://github.com/spree/spree/pull/4331 .

You are probably aware that there are some failing tests currently on master. I was not able to verify the correctness of this commit. Hopefully we can work together to resolve?

Cheers

JDutil commented 10 years ago

I fixed one of the failing tests, but I'm not sure why the other is still failing unless it's due to caching which is possible.

JDutil commented 10 years ago

I've confirmed the other is a caching issue. I'll work up a fix in spree frontend.

JDutil commented 10 years ago

I've addressed the caching issue, and specs are now passing for this extension.

JDutil commented 10 years ago

Merged to master and 2-2-stable w/ ab674e3090b1cd6728ff686ba63d30200737e02e