search

spree-contrib / spree_multi_currency

Provides UI to allow configuring multiple currencies in Spree.
http://guides.spreecommerce.org
BSD 3-Clause "New" or "Revised" License
41 stars 118 forks source link

Currency select drop down does not auto-update #24

Open jameshilliard opened 10 years ago

jameshilliard commented 10 years ago

gemfile.lock https://gist.github.com/jameshilliard/bcca2e8b9fc15e213c9d steps to reproduce: enable multi currency support allow user to change currency select alternate currency using dropdown menu currency does not update when selecting new currency

jameshilliard commented 10 years ago

I made a new test store and it would appear there is some sort of conflict with the spree_fancy theme https://github.com/spree/spree_fancy

masterkain commented 10 years ago

whops, don't forget to run rails generate spree_multi_currency:install, fixed it for me by appending the assets to the pipeline :+1:

jameshilliard commented 10 years ago

Seems I was having issues with products in cart blocking currency change. At least if those products didn't have an alternate currency set.

alepore commented 9 years ago

yes, when a cart item is not available on the requested currency an exception is raised, like: RuntimeError (no RUB price found for Ruby on Rails Tote (ROR-00011)): and the submit will silently fail.

we need a strategy to handle this situation, like removing the product from the cart and/or display a proper message to the user.

aishmita-aggarwal commented 8 years ago

@priyank-gupta @damianlegawiec Currently after user updates currency, we are raising exception for line items that do not have price with selected currency. This tends to mislead the user. I think we should show unavailability error for the line item and keep the currency unchanged. What are your thoughts for this?

priyank-gupta commented 8 years ago

@aishmita-aggarwal Yeah, unavailability error is good than raising exceptions. @damianlegawiec Thoughts?

Mafi88 commented 8 years ago

I think we should show unavailability error for the line item and keep the currency unchanged.

@aishmita-aggarwal You mean something like If you want to change currency, you need to remove these products from cart: (list)?

I think it's better than just removing products withproper message. @damianlegawiec What's your opinion?

aishmita-aggarwal commented 8 years ago

"I think it's better than just removing products withproper message."

@Mafi88 Those variants do not have prices with the updated currency. So are you suggesting that we should remove the unavailable items and just notify the user?

@priyank-gupta @damianlegawiec ?

Mafi88 commented 8 years ago

@aishmita-aggarwal No, I think message like this: If you want to change currency, you need to remove these products from cart: (list) is better.