search

spree-contrib / spree_multi_vendor

Spree marketplace extension. Create your own marketplace on top of Spree Commerce
https://spreecommerce.org/marketplace-ecommerce/
BSD 3-Clause "New" or "Revised" License
142 stars 135 forks source link

Fix Spree::Stock::PackageDecorator; Don't assign boolean value to `vendor` #132

Closed hoshinotsuyoshi closed 4 years ago

hoshinotsuyoshi commented 4 years ago

Hi there,

Today, when I reflected the #130 change in our code (Spree::Stock::PackageDecorator), it didn't work.

NoMethodError
undefined method `shipping_methods' for true:TrueClass

On this line.

It's probably unintended behavior to assign boolean to vendor.

This is the patch. https://github.com/spree-contrib/spree_multi_vendor/commit/05428ae180bd14c453b6c3750adc53fe08addf24

I would be happy if you could see it.

Thank you!

hoshinotsuyoshi commented 4 years ago

Oh, It seems that https://github.com/spree-contrib/spree_multi_vendor/pull/133 solved same issue. I will close this PR. Thank you, @damianlegawiec