search

spree-contrib / spree_multi_vendor

Spree marketplace extension. Create your own marketplace on top of Spree Commerce
https://spreecommerce.org/marketplace-ecommerce/
BSD 3-Clause "New" or "Revised" License
142 stars 135 forks source link

Support Spree 4.5 (with compatibility) #217

Closed JoseMPena closed 1 year ago

JoseMPena commented 1 year ago

Based off JuanseGimenez's PR. Please refer to that link for details.

rafalcymerys commented 1 year ago

@nciemniak this one too :)

rafalcymerys commented 1 year ago

Hi @JoseMPena could you please describe a bit more what's the scope of changes in your PR (compared vs the @JuanseGimenez PR that you mentioned)?

JoseMPena commented 1 year ago

Hi @rafalcymerys Thanks for looking into this. The only relevant change here (vs @JuanseGimenez 's PR) is in base_controller_decorator.rb, Here we're also decorating V2::BaseController, not only V1

rafalcymerys commented 1 year ago

@JoseMPena thanks. I'm looking through the code, but I can't find any usages of current_spree_vendor or set_vendor_id in the V2 endpoints. Is it needed there?

JoseMPena commented 1 year ago

@JoseMPena thanks. I'm looking through the code, but I can't find any usages of current_spree_vendor or set_vendor_id in the V2 endpoints. Is it needed there?

Hi @rafalcymerys You're right!, it can be decorated locally in our project, no need to overload the base repo. Thank you very much for the time invested in this. I'm closing this PR.