Only include "completed" payments?

spree-contrib / spree_print_invoice

Create a PDF invoice for Spree orders.

http://guides.spreecommerce.org

BSD 3-Clause "New" or "Revised" License

91 stars 239 forks source link

Open naw opened 8 years ago

naw commented 8 years ago

The invoice template displays all payments for an order, even invalid or failed ones.

As a new user to this gem, I would have expected only "completed" payments to be displayed in the invoice PDF by default.

WDYT?

tvdeyen commented 8 years ago

Seams reasonable. We override the default templates in our projects, so we don't know of any issues being in the defaults.

Please send a pull request that fixes this. Thanks

mdavo6 commented 3 years ago

@damianlegawiec This issue can be closed, as was resolved by PR #125